BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

Sieve and Forestry Saplings #125

Closed Sunekaer closed 5 years ago

Sunekaer commented 6 years ago

Hey

So im trying to add forestry sapling to the SieveRegistry but cant get it to work, could you assist me?

This is the sapling i would like to add <forestry:sapling>.withTag({IsAnalyzed: 0 as byte, Genome: {Chromosomes: [{UID1: "forestry.treeOak", UID0: "forestry.treeOak", Slot: 0 as byte}, {UID1: "forestry.heightSmall", UID0: "forestry.heightSmall", Slot: 1 as byte}, {UID1: "forestry.saplingsAverage", UID0: "forestry.saplingsAverage", Slot: 2 as byte}, {UID1: "forestry.fruitApple", UID0: "forestry.fruitApple", Slot: 3 as byte}, {UID1: "forestry.yieldLowest", UID0: "forestry.yieldLowest", Slot: 4 as byte}, {UID1: "forestry.sappinessLowest", UID0: "forestry.sappinessLowest", Slot: 5 as byte}, {UID1: "forestry.leavesNone", UID0: "forestry.leavesNone", Slot: 6 as byte}, {UID1: "forestry.maturationFaster", UID0: "forestry.maturationFaster", Slot: 7 as byte}, {UID1: "forestry.i1d", UID0: "forestry.i1d", Slot: 8 as byte}, {UID1: "forestry.fireproofFalse", UID0: "forestry.fireproofFalse", Slot: 9 as byte}]}})

but when i take that data with in withTag(), and paste it in to "nbt": it crashes my SieveRegistry..

"forestry:humus": [ { "drop": { "name": "forestry:sapling", "meta": 0, "nbt": { IsAnalyzed: 0 as byte, Genome: { Chromosomes: [{ UID1: "forestry.treeOak", UID0: "forestry.treeOak", Slot: 0 as byte }, { UID1: "forestry.heightSmall", UID0: "forestry.heightSmall", Slot: 1 as byte }, { UID1: "forestry.saplingsAverage", UID0: "forestry.saplingsAverage", Slot: 2 as byte }, { UID1: "forestry.fruitApple", UID0: "forestry.fruitApple", Slot: 3 as byte }, { UID1: "forestry.yieldLowest", UID0: "forestry.yieldLowest", Slot: 4 as byte }, { UID1: "forestry.sappinessLowest", UID0: "forestry.sappinessLowest", Slot: 5 as byte }, { UID1: "forestry.leavesNone", UID0: "forestry.leavesNone", Slot: 6 as byte }, { UID1: "forestry.maturationFaster", UID0: "forestry.maturationFaster", Slot: 7 as byte }, { UID1: "forestry.i1d", UID0: "forestry.i1d", Slot: 8 as byte }, { UID1: "forestry.fireproofFalse", UID0: "forestry.fireproofFalse", Slot: 9 as byte }] } } }, "chance": 0.08, "meshLevel": 1 } ]

SirLyle commented 6 years ago

Please upload your Jason file and crash log to pastebin.

Sunekaer commented 6 years ago

Its not crashing the game, its when i add this part, none of the stuff from my SieveRegistry.json gets loaded "forestry:humus": [ { "drop": { "name": "forestry:sapling", "meta": 0, "nbt": { IsAnalyzed: 0 as byte, Genome: { Chromosomes: [{ UID1: "forestry.treeOak", UID0: "forestry.treeOak", Slot: 0 as byte }, { UID1: "forestry.heightSmall", UID0: "forestry.heightSmall", Slot: 1 as byte }, { UID1: "forestry.saplingsAverage", UID0: "forestry.saplingsAverage", Slot: 2 as byte }, { UID1: "forestry.fruitApple", UID0: "forestry.fruitApple", Slot: 3 as byte }, { UID1: "forestry.yieldLowest", UID0: "forestry.yieldLowest", Slot: 4 as byte }, { UID1: "forestry.sappinessLowest", UID0: "forestry.sappinessLowest", Slot: 5 as byte }, { UID1: "forestry.leavesNone", UID0: "forestry.leavesNone", Slot: 6 as byte }, { UID1: "forestry.maturationFaster", UID0: "forestry.maturationFaster", Slot: 7 as byte }, { UID1: "forestry.i1d", UID0: "forestry.i1d", Slot: 8 as byte }, { UID1: "forestry.fireproofFalse", UID0: "forestry.fireproofFalse", Slot: 9 as byte }] } } }, "chance": 0.08, "meshLevel": 1 } ]

and the ex nihilo log only says

[15:42:38] [INFO] ModConfig Loaded: true [15:42:38] [INFO] JEI: Compost Recipe Pages Loaded: 2 [15:42:38] [INFO] JEI: Fluid Block Transform Recipes Loaded: 23 [15:42:38] [INFO] JEI: Fluid On Top Recipes Loaded: 2 [15:42:38] [INFO] JEI: Fluid Transform Recipes Loaded: 2 [15:42:38] [INFO] JEI: Hammer Recipes Loaded: 32 [15:42:38] [INFO] JEI: Heat Sources Loaded: 11 [15:42:38] [INFO] JEI: Sieve Recipes Loaded: 0 [15:42:38] [INFO] JEI: Stone Crucible Recipes Loaded: 1

SieveRegistry.zip

BloodWorkXGaming commented 6 years ago

That's because /ct hand gives a different syntax than the normal json... I know craftgroovy has a command for it, buut that's just tedious to install it for that. Might need a command here or in crt.

Sunekaer notifications@github.com schrieb am Di., 9. Okt. 2018, 19:41:

Its not crashing the game, its when i add this part, none of the stuff from my SieveRegistry.json gets loaded "forestry:humus": [ { "drop": { "name": "forestry:sapling", "meta": 0, "nbt": { IsAnalyzed: 0 as byte, Genome: { Chromosomes: [{ UID1: "forestry.treeOak", UID0: "forestry.treeOak", Slot: 0 as byte }, { UID1: "forestry.heightSmall", UID0: "forestry.heightSmall", Slot: 1 as byte }, { UID1: "forestry.saplingsAverage", UID0: "forestry.saplingsAverage", Slot: 2 as byte }, { UID1: "forestry.fruitApple", UID0: "forestry.fruitApple", Slot: 3 as byte }, { UID1: "forestry.yieldLowest", UID0: "forestry.yieldLowest", Slot: 4 as byte }, { UID1: "forestry.sappinessLowest", UID0: "forestry.sappinessLowest", Slot: 5 as byte }, { UID1: "forestry.leavesNone", UID0: "forestry.leavesNone", Slot: 6 as byte }, { UID1: "forestry.maturationFaster", UID0: "forestry.maturationFaster", Slot: 7 as byte }, { UID1: "forestry.i1d", UID0: "forestry.i1d", Slot: 8 as byte }, { UID1: "forestry.fireproofFalse", UID0: "forestry.fireproofFalse", Slot: 9 as byte }] } } }, "chance": 0.08, "meshLevel": 1 } ]

and the ex nihilo log only says `[15:42:38] [INFO] ModConfig Loaded: true [15:42:38] [INFO] JEI: Compost Recipe Pages Loaded: 2 [15:42:38] [INFO] JEI: Fluid Block Transform Recipes Loaded: 23 [15:42:38] [INFO] JEI: Fluid On Top Recipes Loaded: 2 [15:42:38] [INFO] JEI: Fluid Transform Recipes Loaded: 2 [15:42:38] [INFO] JEI: Hammer Recipes Loaded: 32 [15:42:38] [INFO] JEI: Heat Sources Loaded: 11 [15:42:38] [INFO] JEI: Sieve Recipes Loaded: 0 [15:42:38] [INFO] JEI: Stone Crucible Recipes Loaded: 1

SieveRegistry.zip https://github.com/BloodyMods/ExNihiloCreatio/files/2461572/SieveRegistry.zip `

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BloodyMods/ExNihiloCreatio/issues/125#issuecomment-428283949, or mute the thread https://github.com/notifications/unsubscribe-auth/AHwpZmZEZ69W8QzuVM-aOIBL5-CCqZX3ks5ujN-zgaJpZM4XTbdI .

Sunekaer commented 6 years ago

Okay ill try with craftgroovy ty

BloodWorkXGaming commented 6 years ago

Don't fully remember the command, was something along the lines of /cg nbt or something....

Sunekaer notifications@github.com schrieb am Di., 9. Okt. 2018, 20:04:

Okay ill try with craftgroovy ty

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BloodyMods/ExNihiloCreatio/issues/125#issuecomment-428291768, or mute the thread https://github.com/notifications/unsubscribe-auth/AHwpZvBFcD29dpPUXVkvum7fMl3krBaeks5ujOU0gaJpZM4XTbdI .

Sunekaer commented 6 years ago

/cg hand that works thank you guys

Sunekaer commented 6 years ago

Hey so new problem

i added 35 forestry saplings, but when i load up the game it only shows it as one recipe

fsapling

SieveRegistry.zip

log: [21:18:01] [INFO] ModConfig Loaded: true [21:18:01] [INFO] JEI: Compost Recipe Pages Loaded: 2 [21:18:01] [INFO] JEI: Fluid Block Transform Recipes Loaded: 23 [21:18:01] [INFO] JEI: Fluid On Top Recipes Loaded: 2 [21:18:01] [INFO] JEI: Fluid Transform Recipes Loaded: 2 [21:18:01] [INFO] JEI: Hammer Recipes Loaded: 32 [21:18:01] [INFO] JEI: Heat Sources Loaded: 11 [21:18:01] [INFO] JEI: Sieve Recipes Loaded: 26 [21:18:01] [INFO] JEI: Stone Crucible Recipes Loaded: 1

BloodWorkXGaming commented 6 years ago

Does it drop correctly tho? So issue with jei or whole thing?

Sunekaer notifications@github.com schrieb am Di., 9. Okt. 2018, 21:24:

Hey so new problem

i added 35 forestry saplings, but when i load up the game it only shows it as one recipe

[image: fsapling] https://user-images.githubusercontent.com/18720460/46693169-5bb28c00-cc09-11e8-8ef3-c7f1f986c195.PNG

SieveRegistry.zip https://github.com/BloodyMods/ExNihiloCreatio/files/2461845/SieveRegistry.zip

log: [21:18:01] [INFO] ModConfig Loaded: true [21:18:01] [INFO] JEI: Compost Recipe Pages Loaded: 2 [21:18:01] [INFO] JEI: Fluid Block Transform Recipes Loaded: 23 [21:18:01] [INFO] JEI: Fluid On Top Recipes Loaded: 2 [21:18:01] [INFO] JEI: Fluid Transform Recipes Loaded: 2 [21:18:01] [INFO] JEI: Hammer Recipes Loaded: 32 [21:18:01] [INFO] JEI: Heat Sources Loaded: 11 [21:18:01] [INFO] JEI: Sieve Recipes Loaded: 26 [21:18:01] [INFO] JEI: Stone Crucible Recipes Loaded: 1

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BloodyMods/ExNihiloCreatio/issues/125#issuecomment-428318933, or mute the thread https://github.com/notifications/unsubscribe-auth/AHwpZjBGtseQ0BEQruCa9f7WraQjtUb9ks5ujPfYgaJpZM4XTbdI .

Sunekaer commented 6 years ago

the whole thing it only drops the Apple Oak Sapling, but random amounts, first i got 4 then 1 then 5 then 3

Sunekaer commented 6 years ago

Im using forge 2768 and forestry_1.12.2-5.8.1.350 if you guys need that info, but it also happened on older versions of forge and forestry https://minecraft.curseforge.com/projects/stoneblock/files/2626239

SirLyle commented 6 years ago

There is a bug in the latest version of of the JSON parser, not sure that bug got pushes yet. Not sure if it is related. But once I patched in dev I got different saplings.

The JEI compat does have a bug (it ignores NBT when deciding if items are equal). Can you test it with this build (mediafire link) It should have the correct drops and JEI working.

If that works then the fix is included in my existing pull req.

SynexWolf commented 5 years ago

It kind of fixed it? It now shows up separately but the chances are still grouped in the tool tip. image

SieveRegistry.json { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "aer"}] } }, "chance": 0.05, "meshLevel": 4 }, { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "ignis"}] } }, "chance": 0.05, "meshLevel": 4 }, { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "aqua"}] } }, "chance": 0.05, "meshLevel": 4 }, { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "terra"}] } }, "chance": 0.05, "meshLevel": 4 }, { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "perditio"}] } }, "chance": 0.05, "meshLevel": 4 }, { "drop": { "name": "thaumcraft:crystal_essence", "meta": -1, "nbt": { "Aspects": [{"amount": 1, "key": "ordo"}] } }, "chance": 0.05, "meshLevel": 4 } Also, unsure if it's related to your side, but ExCompressum still has the issue, it's still showing up as one item, but the drops seems to be correct.

SirLyle commented 5 years ago

Does this issue persist in the latest version? The sieve JEI plugin was rewritten.

Ex Compressum has their own JEI plugins so it would be on their side.

Edit: nvm, the part that makes the tooltip is still using the old itemstack comparison method. That will be updated in the next version.

SirLyle commented 5 years ago

Merged. Adding to curse soon.