BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

Infested Leaves Crucible Crash #140

Closed ghost closed 5 years ago

ghost commented 5 years ago

MC 1.12.2 Forge: 2796 EX Nihilo Creatio: 1.12-0.3.2

I added Infested Leaves to the CrucibleRegistryWood.json file and when trying to right click the leaves into the crucible I get the following crash.

https://pastebin.com/YGdDKUVN

SirLyle commented 5 years ago

So the I think the reason is because infesting use an animated renderer (to do the color fade), which doesn't have a model to pull the sprite from. It should work if you define the "color" override in the json file. I've added a null check to the rendering code so while it might not render anything, it shouldn't cause crashes.

SirLyle commented 5 years ago

Fix pushed to curse.

ghost commented 5 years ago

Thank you for safe guarding against this.