BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

No JEI for Sieves #155

Closed CritFlaw closed 5 years ago

CritFlaw commented 5 years ago

The latest version of Ex Nihilo, sieve recipes don't show up in JEI, instead only showing Ex Compressum's heavy sieve. Tried with and without json loading.

Forge version 2796 Mod version 0.3.5.1

SirLyle commented 5 years ago

Are you attempting to look up the recipes using the sieve or the meshes? I can see them if I look them up with the sieves.

CritFlaw commented 5 years ago

With the sieves.

SirLyle commented 5 years ago

Can you please provide your log, there may be an "[Client thread/ERROR] [jei]" where the JEI plugin is failing. Try searching your logs for "exnihilocreatio.compatibility.jei.CompatJEI"

CritFlaw commented 5 years ago

Yes, there does seem to be an issue happening with JEI https://gist.github.com/CritFlaw/79bb9e459cadd52ff1e79e3650c079b8

SirLyle commented 5 years ago

Appears to actually be a problem with the ex nihilo JEI plugin.

SirLyle commented 5 years ago

Issue is related to Issue #150, basically even though the tinkers derived class is never called, Java is trying to validate the classes.

CritFlaw commented 5 years ago

Lovely

SirLyle commented 5 years ago

Fix pushed to curse.

CritFlaw commented 5 years ago

Ok, that does fix it, but now we're back to pre-2019 problems, with it doing this: https://imgur.com/a/0WgleBt

SirLyle commented 5 years ago

I don't think that was ever fixed.

CritFlaw commented 5 years ago

Oh, I assumed that was one of the things addressed in the initial update....

SirLyle commented 5 years ago

I think @Tencao had a branch where he was working on that. The big initial update was just my dev branch.

CritFlaw commented 5 years ago

Is it the same issue Ex Compressum is having? https://github.com/blay09/ExCompressum/issues/261

SirLyle commented 5 years ago

Probably. Basically the JEI plugin was never designed for a large number of possible drops. It has to basically be completely re-written. I haven't seen anything in the JEI API that is really designed for limited inputs -> massive number of outputs.

Issue #126 is still open for this topic.

CritFlaw commented 5 years ago

What about lootbags? They have this working.

SirLyle commented 5 years ago

Uses a custom license so not to keen on just ripping off their code.

CritFlaw commented 5 years ago

Ah, I see... well that sucks. I'll limit items to fit.