BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

Crooking infested leaves' string drop chance #158

Closed Stormalisk closed 5 years ago

Stormalisk commented 5 years ago

I have been trying to make crooks not always drop 2 string when harvesting infested leaves, as my modpack does not revolve around skyblock and I don't want it to overshadow harvestcraft cotton or other string obtainment methods. So far the only "nerf" I can give them is to make their tick time obscenely long.

crooking { D:stringChance=0.5 D:stringFortuneChance=0.5 } Changing those two options only seems to affect drop rates when NOT crooking, as no matter the setting a crook will always force two string to drop per block.

I am unsure if this is the intentional behavior or not of those settings.

SirLyle commented 5 years ago

There appears to be a missing check in BlockInfestedLeaves.onBlockHarvest(...).

SirLyle commented 5 years ago

A fix has been merged and uploaded to curse, Version 0.3.7.