BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

[Suggestion] Configurable mob transform (by witchwater) registry #224

Open KiBergMK opened 5 years ago

SirLyle commented 5 years ago

The biggest hold-up preventing this is I haven't figured out a good way to prevent looping (i.e. game freezing) or how to handle the villager professions (e.g. Illigers). Or the special handling that slimes -> magma slimes require.

Insane96 commented 5 years ago

Why should the game freeze for looping?

KiBergMK commented 5 years ago

I just want to add transform red mushroom cow to brown (from "Brown Mooshrooms" mod), and back. OR Make transform cow to brown/red cow with chance 50/50

SirLyle commented 5 years ago

I got game freezes when Mob1 -> Mob2 -> Mob1 because each mob was firing the change code in the same tick they were created in so it was infinitely looping within a single tick. It could be handled by preventing the registration of recipes which result in something that is a valid input.

The bigger design issue is not losing the current villager profession changes.

Insane96 commented 5 years ago

Maybe add a cooldown or a tag that if a mob has been transformed can no longer be transformed anymore

Il Sab 18 Mag 2019, 16:36 SirLyle notifications@github.com ha scritto:

I got game freezes when Mob1 -> Mob2 -> Mob1 because each mob was firing the change code in the same tick they were created in so it was infinitely looping within a single tick. It could be handled by preventing the registration of recipes which result in something that is a valid input.

The bigger design issue is not losing the current villager profession changes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BloodyMods/ExNihiloCreatio/issues/224?email_source=notifications&email_token=ABW2FUDCCNM44XVUNREMPCTPWAIAHA5CNFSM4HNXZAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWPY2I#issuecomment-493681769, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW2FUF4FLY4JIERUXSLQLLPWAIAHANCNFSM4HNXZAHQ .