search

BloodyMods / ExNihiloCreatio

Ex Nihilo with progression!
MIT License
25 stars 20 forks source link

Fix /dank/null incompatibility+updates #265

Closed p455w0rd closed 5 years ago

p455w0rd commented 5 years ago

so, I am actually unable to test after spending 2 hours trying to just get stuff to load...there's a ton of dep issues when building from scratch..anway..fixed the /dank/null stuff...it functions identically to normal ItemHandlers now, so removing the proprietary code actually fixes the bug

SirLyle commented 5 years ago

To fix the build environment

  1. Set useDepAts to false
  2. setupDecompWorkspace
  3. set useDepAts to true

I'm probably going to end up just removing the dank/null dep completely since it now is suppose functions as a normal itemhandler.

Unfortunately /dank/null crashes whenever I open a /dank/null; even on an instance with just /dank/null and p455W0rdlib, so I can't test if it is working.

java.lang.NoSuchMethodError: net.minecraft.item.Item.getForgeRarity(Lnet/minecraft/item/ItemStack;)Lnet/minecraftforge/common/IRarity;
    at p455w0rd.danknull.client.gui.GuiDankNull.func_146285_a(GuiDankNull.java:544)
    at p455w0rd.danknull.client.gui.GuiDankNull.func_73863_a(GuiDankNull.java:266)
    at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:396)
    at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1124)
    ...

Is this a known bug or should I open an issue?

SirLyle commented 5 years ago

Nvm, I think that was added in a newer forge version; /dank/null should restrict its valid versions to 2816 or higher.

https://github.com/mezz/JustEnoughItems/issues/1549

SirLyle commented 5 years ago

Closing as Pull Req #267 implements this; and removes the dependency from the build environment completely.