search

BloodyMods / ServerStarter

MIT License
99 stars 62 forks source link

Remove InternetManager.checkConnection() ? #58

Closed CubeSugarCheese closed 2 years ago

CubeSugarCheese commented 2 years ago

Why?

I think this check is Unnecessary. If you can connect to google.com, it doesn't mean you can connect other domain. vice versa.

Suggestion

remove the internet checking. All http request should use try and catch request Exceptions. while exception occurs, program should catch and report it (with detailed stack trace).

LauJosefsen commented 2 years ago

I agree, there is no real reason to check for connection to arbitrary domains at startup.

A connection to google or curseforge at startup, does definitely not assure the program that the next http request to curseforge will not fail.

See also #52 #53 #55

BloodWorkXGaming commented 2 years ago

Added a configurable list of servers, and it also won't exit but rather only warn the user now in 2.3.0 :)