BloodyMods / ServerStarter

MIT License
100 stars 64 forks source link

[feature][fabric] support `{{@mcversion@}}` and `{{@loaderversion@}}` in `installerArguments` and add `installerVersion` #69

Open FederAndInk opened 2 years ago

FederAndInk commented 2 years ago

the fabric installer needs to be called with minecraft and loader version, it could be great to inject those variable in the installerArguments:

  installerArguments:
    - "server"
    - "-downloadMinecraft"
    - "-mcversion"
    - "{{@mcversion@}}"
    - "-loader"
    - "{{@loaderversion@}}"

Also this doesn't work, as the loaderVersion is not the same as the installer version for fabric:

https://github.com/BloodyMods/ServerStarter/blob/d13247e2f278741692bbac41cca8ab1f8790af9a/server-setup-config.yaml#L31

For instance the fabric installer: https://maven.fabricmc.net/net/fabricmc/fabric-installer/0.11.0/fabric-installer-0.11.0.jar and it could be called like this: java -jar fabric-installer-0.11.0.jar server -downloadMinecraft -mcversion 1.18.2 -loader 0.14.8

So it could be great to also add installerVersion to be able to do:

  installerUrl: "https://maven.fabricmc.net/net/fabricmc/fabric-installer/{{@installerversion@}}/fabric-installer-{{@installerversion@}}.jar"