Bloom-host / Petal

A performance-oriented fork of Purpur intended to increase performance for entity-heavy servers by implementing multi-threaded and asynchronous improvements.
GNU General Public License v3.0
223 stars 22 forks source link

Citizens inconsistencies #3

Open matipoirierg opened 2 years ago

matipoirierg commented 2 years ago

Hi, I'm having some citizen inconsistencies using petal. Npc dissapears sometimes but it's not for all players, some can see them, some not (players that can see them eventually won't be able to). Sometimes if you quit and re-join you'll start seeing NPCs again. It seems like one trigger of the issue is to going too far from a npc and going back but I'm not completely sure. Sorry for not being more specific, but the issue behaves pretty randomly.

KayaEdwin commented 2 years ago

Hey! Could you send a list of your plugins, and a spark/timings report to view settings? That'll help in further looking into the issue

matipoirierg commented 2 years ago

Hey! Could you send a list of your plugins, and a spark/timings report to view settings? That'll help in further looking into the issue Issue persist with the latest build sent to discord by Abby. https://spark.lucko.me/EZ75M8g64Y

Plugins (85): AdvancedEnchantments, AdvancedPortals, BeastWithdraw, BetterRTP, BlockBall, BlockParticles, Boss, CAProtect-Lite, ChatItem, ChatSentinel, Citizens, CMILib, CommandPerWorldBlocker, CoreProtect, CraftingStore, CrazyCrates, CyberWorldReset, DecentHolograms, DeluxeCombat, DeluxeMentions, DeluxeMenus, DiscordSRV, EasyCommandBlocker, Essentials, EssentialsProtect, EssentialsSpawn, EZRanksPro, FlightControl, Graves, GSit, Harbor, HeadDatabase, HideAchievements, InventoryRollbackPlus, Jobs, LiteBans, LPC, LuckPerms, mcMMO, MineableSpawners, Minepacks, MobEggDrop, MobFarmManager, Multiverse-Core, Multiverse-NetherPortals, MyCommand, NoChunkLag, OpenAudioMc, OpenInv, OreAnnouncer, PinataParty, PlaceholderAPI, PlayerWarps, PlugManX (PlugMan), PremiumVanish, ProCosmetics, ProtectionStones, ProtocolLib, Quests, QuickShop, RecyclerPlus, SafeNET, ShopGUIPlus, Shopkeepers, SkinsRestorer, spark, STN-Studios-API, StoreStats, SuperLuckyBlock, TAB, TradeSystem, UltimateAirdrops, UltimateAutoRestart, Vault, Vehicles, ViaBackwards, ViaVersion, VipSlot*, VoidGen, VoidSpawn, Votifier, WorldEdit, WorldGuard, WorldGuardExtraFlags, zAuctionHouseV3

matipoirierg commented 2 years ago

Also I would like to suggest the feature to toggle the entity tracker per world, I think that most people use citizens in the spawn that is generally a separated world from the survival one, this could work as a temporary fix.

WarnDa commented 2 years ago

(Just to be sure, it's not related to this ? https://github.com/CitizensDev/Citizens2/issues/2696)

matipoirierg commented 2 years ago

no, I can only reproduce the error using petal

KayaEdwin commented 2 years ago

Issue still occuring in the latest pre-release, I'll check tonight if I can find any related errors

noramibuu commented 2 years ago

I'm able to reproduce too

peaches94 commented 2 years ago

how is it reproduced?

noramibuu commented 2 years ago

how is it reproduced?

Well, it's just randomly happens. I have like 20 Citizen NPCs and sometimes me or my friends noticing half or all of them are invisible. I tried to delete all NPCs and create again, at first it fixed but a bit later they were vanished again. I unfortunetly can't share all plugin list but I don't have a plugin changes mobs behaviour. Important and big-sized plugins i can count is listed at below. If it's necessary, i can try with no plugins too.

AutoShulker, BKCommonLib, Citizens, CombatLogX, DecentHolograms, Denizen, Essentials, FarmControl, InventoryRollbackPlus, LibsDisguises, LuckPerms, Maintenance, Multiverse-Core, Panilla, PlaceholderAPI, ProtocolLib, Recipy, Sentinel, Skript, skript-gui, skript-reflect, Skulls, spark, StackResize, Stress, TAB, ToolKit, Vault, VoidGen, WolfyUtilities, WorldEdit, WorldGuard, YamipaPlugin

noramibuu commented 2 years ago

how is it reproduced?

Well, it's just randomly happens. I have like 20 Citizen NPCs and sometimes me or my friends noticing half or all of them are invisible. I tried to delete all NPCs and create again, at first it fixed but a bit later they were vanished again. I unfortunetly can't share all plugin list but I don't have a plugin changes mobs behaviour. Important and big-sized plugins i can count is listed at below. If it's necessary, i can try with no plugins too.

AutoShulker, BKCommonLib, Citizens, CombatLogX, DecentHolograms, Denizen, Essentials, FarmControl, InventoryRollbackPlus, LibsDisguises, LuckPerms, Maintenance, Multiverse-Core, Panilla, PlaceholderAPI, ProtocolLib, Recipy, Sentinel, Skript, skript-gui, skript-reflect, Skulls, spark, StackResize, Stress, TAB, ToolKit, Vault, VoidGen, WolfyUtilities, WorldEdit, WorldGuard, YamipaPlugin

Also, at first I thought It's a Citizen bug because I had same problem at 2016 too but I newly moved to Petal and while I was using Pufferfish, i and my friends noticed a vanished NPC. I didn't change a single plugin's version after I moved to Petal

JustAMatt commented 2 years ago

Important note: This issue only happens when the NPC has a player skin, if it uses a mob skin it will not despawn. @peaches94

pinusbrutia commented 2 years ago

i'm able to reproduce too in latest version without any plugin except Citizens and Sentinel

Spliterash commented 2 years ago

+1, citizens works wrong on petal and all ok on paper

HamtaBot commented 2 years ago

after some testing when NPC are despawning im getting those logs on my minecraft client https://bin.bloom.host/ajenasixaw.apache

erg43hergeg commented 2 years ago

i have the same error on latest purpur

SnowzNZ commented 2 years ago

Can also confirm this.

MrButtersDEV commented 2 years ago

Any updates on this issue?

SnowzNZ commented 2 years ago

Any updates on this issue?

This has been fixed in the latest release

bigdaddyky commented 2 years ago

Any updates on this issue?

This has been fixed in the latest release

Me and @MrButtersDEV have tested this out and it did not patch our issue with player skins disappearing. (Yes i can confirm our issue is to do with petal)

MrButtersDEV commented 1 year ago

Does anyone have any updates on this? That's not using Mirai and disabling async entity tracker?

bigdaddyky commented 1 year ago

Issue seems to occur when a player loads a chunk with the player NPC and then another player/s start to load it. If the person who loaded the chunk originally, leaves, the next player to load the chunk will then see it.