BloomGameStudio / BloomDiscordBot

1 stars 1 forks source link

Updates #7

Closed Sarahtonein closed 10 months ago

Sarahtonein commented 11 months ago

Added the following functionality:

!listevents command list ALL events past and present that are in the Bloom Discord server

!deleteevent command deletes an event. It needs to be passed an event ID with the command.

Scheduled task that will check for events within the next 24 hours once a day. If events are found it will log them to a specified channel and use the @ here to inform people of the upcoming event/s

When new events are created, there is an hour delay in which the person creating the event can make changes to the name / description etc.

Sarahtonein commented 11 months ago

To clarify on !listevents, it will only list events that are still visible within the Bloom Discord server. Once an event has been ended / deleted it will no longer show.

Sarahtonein commented 11 months ago

@Balugrizzly , same with this branch

Balugrizzly commented 11 months ago

same as what with this branch?

Balugrizzly commented 11 months ago

You have linked the help ticket to this which will be closed after merge is this intended? The help command should exist for the whole bot in its entirety

Balugrizzly commented 11 months ago

merge conflicts

Sarahtonein commented 11 months ago

Consider opening your files once instead of multiple times and duplicating the functionality. Same goes for similar operations

Ah I see what you mean. 👍🏼

Sarahtonein commented 11 months ago

same as what with this branch?

Oh I was just mentioning that this PR was updated from the putting_it_together branch. You can disregard that comment.

Sarahtonein commented 11 months ago

You have linked the help ticket to this which will be closed after merge is this intended? The help command should exist for the whole bot in its entirety

I intended to handle that issue in this branch / PR, but I can create another branch for that issue specifically?

Sarahtonein commented 11 months ago

Consider opening your files once instead of multiple times and duplicating the functionality. Same goes for similar operations

I was thinking about this and as its a small file wouldn't it be better to open and close as it's just a small file? Wouldn't there potentially be data loss if the bot was restarted / crashed and the file had not been closed / saved?

Balugrizzly commented 11 months ago

You have linked the help ticket to this which will be closed after merge is this intended? The help command should exist for the whole bot in its entirety

I intended to handle that issue in this branch / PR, but I can create another branch for that issue specifically?

As long as the help command is available for everything its ok

Balugrizzly commented 11 months ago

Consider opening your files once instead of multiple times and duplicating the functionality. Same goes for similar operations

I was thinking about this and as its a small file wouldn't it be better to open and close as it's just a small file? Wouldn't there potentially be data loss if the bot was restarted / crashed and the file had not been closed / saved?

What you state is unrelated to what i mentioned The size of the file has no significance in this. May i suggest implementing it in a way that data loss by design does not occur :) I think that would be beneficial The implementation is not the only thing the duplication and the referencing or the lack there of is one

Sarahtonein commented 11 months ago

Can you explain your directory structure layout If you want we can postpone this and revisit when you bring the three branches together I would lean towards a domain separation or responsibility sections

I was thinking of separating into:

Discord package related:

Commands / Events / Tasks

And then separate folders for:

Emojis/Emotes

Updates/Events

Governance/Proposals

Snapshot

Sarahtonein commented 10 months ago

Up to you on how you want to proceed

Happy to merge both of updates and emotes after my changes yesterday. Tested both and are OK.