BloomhouseMC / Bewitchment-Plus

6 stars 9 forks source link

1337Fleece Recipe conflicts with every other recipe in the game due to misnomenated tags #29

Open antonhibl opened 1 year ago

antonhibl commented 1 year ago

The recipe for 1337Fleece has some errors:

{
  "type": "crafting_shapeless",
  "ingredients": [
    {
      "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    },
    {
        "tag": "bwplus:fleece"
    }
  ],
  "result": {
    "item": "bwplus:rgb_witch_wool",
    "count": 9
  }
}

in game it appears as:

Screenshot 2023-04-12 at 3 10 49 AM

I believe to fix this the tags should be replaced by proper item IDs or proper tags for witch wool items which is what 1337Fleece derives from.

antonhibl commented 1 year ago

to clarify on the title, because it thinks it can craft 1337Fleece from nothing, it tries to craft 1337Fleece for every in-game crafting recipe.

antonhibl commented 1 year ago

so far the best solution to this is to remove the recipe using something like kubejs.

Sunconure11 commented 1 year ago

https://discord.gg/hpDv9FQJAS

Discord for the mod is here. See if you can raise the issue a bit.

AnidemDex commented 1 year ago

Any update on this issue?

muon-rw commented 1 year ago

An easier solution is to just populate this missing tag yourself with a datapack. I have done this for my modpack and can upload it to share if BWPlus isn’t planning on fixing it themselves.