search

Bloomstack / frappe-sentry

Sentry integration for Frappe Framework
Other
13 stars 36 forks source link

Consider merging #7

Open ddavidebor opened 4 years ago

ddavidebor commented 4 years ago

Hello, Please consider merging with frappe when you feel it's as stable as it should be!

David

Alchez commented 4 years ago

Hey @ddavidebor, thanks for reaching out!

Yes, we do plan to eventually contribute this integration to Frappe, but we're fairly shorthanded to take that up right now.

If you'd like to pick up the contribution for this, that would be okay too :)

Rohan

ddavidebor commented 4 years ago

What work is missing to be done?

David

Alchez commented 4 years ago

There isn't much functionality we will be adding anytime soon, so the things really to do here is to find an elegant way to integrate this as an alternative logger inside Frappe, along with proper documentation and tests.

ddavidebor commented 4 years ago

Perhaps the best way is not using an APP and instead of merging the changes with frappe itself. The dev team could hardcode their sentry info if they wanted, or anybody else could configure it through the system settings and/or environmental variables.

Alchez commented 4 years ago

Sure, I agree, but like I said, we don't have the bandwidth to take this up right now, and we wouldn't mind if someone from the community wanted to go ahead and merge it with Frappe.