Pat - It was great to see how well your goals for the app developed and became real over the course of the project - it’s always rewarding to make something you’re proud of, and we think you’ve done a great job fulfilling that in this app.
Nora - Overall, awesome job! Your app looks clean, polished, and functions very well. Even after a few bumps in the road (from completely pivoting and your mobileprotoathons), everything has come together nicely.
Hieu - Given how view-oriented and therefore detail-oriented this app is, I think you guys have done a great job because it looks stunning and the code, too, is fantastically organized. Well done!
Total: 240/250 :sparkles:
Proposal: 15/15 points
Final Deliverable: 225/235 points
Functionality: 135/140 points
Completion: 85/85 points
MVP is all there, with medium goal of picking up/dropping flag
Bug free: 10/15 points
I can’t sign in on my phone :-( I get “Unable to sign in” and with no other explanation (Nora)
Denying access to location services, and selecting ‘Don’t ask again’ results in graphical glitches where it repeatedly seems to try to ask for permissions, but can’t do so. Other buttons occasionally show up and disappear as well. The developer docs really strongly recommend that you should still maintain some level of functionality if the user denies permissions requests - in this case, it would have been appropriate to display some sort of splash screen saying that you can’t do anything without access to location. This is pretty nitpicky, but it’s the kind of comment you’d get working on a production app for a real company (I know because I spent a week or two just on dumb permissions errors over the summer).
Design/Usability: 40/40 points
Tutorial is great!
Really solid design - looks very polished and professional
Quality: 90/95 points
Git practices: 25/25 pts
Good, effective use of proper version control practices - branching, PRs, etc
Good coding practices: 25/25 pts
onMeasure in the _View.class files should be refactored
Nice design with the API connection + use of RxJava - very cool!
Readability: 20/25 pts
captureFlag’s subscriber in BloopActivity.class could have been refactored more carefully so the method is not as bloated.
Looks clean, but more comments would be helpful to understand code
Pat - It was great to see how well your goals for the app developed and became real over the course of the project - it’s always rewarding to make something you’re proud of, and we think you’ve done a great job fulfilling that in this app.
Nora - Overall, awesome job! Your app looks clean, polished, and functions very well. Even after a few bumps in the road (from completely pivoting and your mobileprotoathons), everything has come together nicely.
Hieu - Given how view-oriented and therefore detail-oriented this app is, I think you guys have done a great job because it looks stunning and the code, too, is fantastically organized. Well done!
Total: 240/250 :sparkles:
Proposal: 15/15 points
Final Deliverable: 225/235 points
Functionality: 135/140 points
Completion: 85/85 points
Bug free: 10/15 points
Design/Usability: 40/40 points
Quality: 90/95 points
Git practices: 25/25 pts
Good coding practices: 25/25 pts
onMeasurein the _View.class files should be refactoredReadability: 20/25 pts
captureFlag’s subscriber inBloopActivity.classcould have been refactored more carefully so the method is not as bloated.Even work distribution: 20/20 pts