Blooym / Wholist

A Dalamud plugin to show which players are near you, alike to World of Warcraft's "/who" command.
GNU Affero General Public License v3.0
5 stars 3 forks source link

POC window position setting #44

Open zbee opened 9 months ago

zbee commented 9 months ago

This is a Proof of Concept for a set window position setting addition. For one, it's a nice setting to have an exact position the window will always show at, but the focus was a setting that would result in the nearby players window not moving when the /xldev menu is shown, which this achieves.

This is in response to this reply to my feedback.

As this is a POC, I don't actually recommend this be merged alone, or at least not without follow-up, but this does prevent the window from moving when the dev menu is shown and does add a minor feature. I marked this as allowing edits to my branch in the case that that would be a cleaner way to build upon this. This could also be a feature without an associated setting, which I think most users may prefer, but I have not gotten into drag events or immediately notice any, which is where I assume you would implement that, so I left that alone.

I also assume that this setting could be moved under a different setting that might make more sense, I did not give a lot of thought to that, and now seeing my image here it could certainly make more sense under other settings.

Here are the settings I added, and showing that the dev menu does not affect them: showing the new settings, and that the window has not moved after the dev menu was drawn

Changes

Should be changed, but wasn't

zbee commented 9 months ago

I assume it will fail until this is rectified:

I Excluded the Strings.Designer.cs regeneration as my IDE needlessly changed the style of everything in it.

I can commit it if you are unconcerned with its formatting.

Blooym commented 9 months ago

I'll add them properly in Rider when I get the time (and get an OSS rider licence lol)

Blooym commented 6 months ago

To update you on this: I plan to redo the Settings UI pretty soon since I'm going through all my plugins doing a bit of UI work so I'll try and get this included as apart of that

I still haven't been able to obtain a Rider licence so I might have to manually do the UI strings too.