search

Blosc / bloscpack

Command line interface to and serialization format for Blosc
BSD 3-Clause "New" or "Revised" License
122 stars 27 forks source link

migrate from nose to pytest #103

Closed bnavigator closed 3 years ago

bnavigator commented 3 years ago

The patch from #99

Any plans to make a new release? 0.16 is broken with current numpy.

esc commented 3 years ago

@bnavigator thank you for submitting this. The project has a single developer and zero financial backing so I've not found the time yet to cut a new release. I can't commit to an exact date yet but I do hope to cut a new release "soon".

Let me know when this is ready to be merged and I'll click the button!

bnavigator commented 3 years ago

I don't know, I guess you have to fix the unrelated test failures first in order to see if this PR is good.

esc commented 3 years ago

Also, I think CI is currently broken... On my wishlist is a migration to GHA

bnavigator commented 3 years ago

On my wishlist is a migration to GHA

Your .travis.yml looks reasonably simple. A really generic GitHub Action workflow show work well.

bnavigator commented 3 years ago

On my wishlist is a migration to GHA

Your wish be granted.

esc commented 3 years ago

On my wishlist is a migration to GHA

Your wish be granted.

Thanks, I will now merge this blindly to run GHA and we can then fix the remaining issues on master.

esc commented 3 years ago

@bnavigator I am not convinced yet, that removing those yields are a good idea.

esc commented 3 years ago

@bnavigator thank you for getting this unstuck btw!

esc commented 3 years ago

@bnavigator do you have a reproducer for 0.16 being broken with Numpy?

bnavigator commented 3 years ago

openSUSE package build:

remove nose patch applied to tag v0.16: https://github.com/bnavigator/bloscpack/tree/v0.16-pytest

esc commented 3 years ago

@bnavigator i believe the patch from #99 was very buggy. I have fixed the code on master now, can you check it?

bnavigator commented 3 years ago

Yes, current master looks good. bloscpack-master.log