Open mmohrhard opened 4 years ago
Hey, I fixed master, can you rebase this and force push please?
I have pushed an updated patch but found one place where the current code is a bit ugly. I'm not too fond of the change in bloscpack/cli.py
but it seems that there can be files without an offset header.
From what I recall, it is possible to disable offsets
in a file with the settings:
https://github.com/blosc/bloscpack#settings
This was done, in case people wanted smaller files with less over head but without the additional features that offsets
enables.
@mmohrhard thanks very much for contributing this, I have added it to the queue for review.
@mmohrhard apologies for the delay, could you rebase this against current master. All CI issues have been fixed there. Thank you!
@mmohrhard hi and welcome to
bloscpack
. Thank you very much for your contribution and your efforts to improvebloscpack
. I just had a look at the CI system and noticed, that the project has been dormant for some time. Hence the tests are not in good shape, they are testing older versions of Python and probably the APIs of the Numpy dependency have changed. This means, it is a bit tricky to work out why the tests are failing. I think it would be a good idea to improve the state of the test suite first before attempting to merge this fix.