Blosc / c-blosc2

A fast, compressed, persistent binary data store library for C.
https://www.blosc.org
Other
430 stars 82 forks source link

Failure compiling on windows with Intel OneAPI #608

Open byrnHDF opened 2 months ago

byrnHDF commented 2 months ago

D:\a\hdf5\hdf5\build\ci-StdShar-Intel_deps\blosc2-src\blosc\directories.c(65,5): error: call to undeclared function 'rmdir'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] rmdir(dir_path);

Adding -Wno-implicit-function-declaration then causes a failure with linking because __cpu_mod is undefined in shuffle.c/blosc_get_cpu_features()

IntelOneAPI is available to use in github CI runners.

FrancescAlted commented 2 months ago

Hi @byrnHDF ! We would be happy to fix this. Would you mind to send a PR?

byrnHDF commented 2 months ago

Not sure how to fix the failure - but Intel OneAPI is LLVM based and CMake identifies it as IntelLLVM. HDF5 workflows use OneAPI for both CMake and autotools, see the intel-*.yml files for our steps. The main step is: `