Open DimitriPapadopoulos opened 3 weeks ago
I like your proposal of making interfaces more uniform. Right now BLOSC_INFO
should not be used beyond developers, so I don't think we will break anything serious if we implement what you are proposing. Would you mind sending a PR?
Describe the bug
I am not sure I understand the tracing macros: https://github.com/Blosc/c-blosc2/blob/3ae32b6de27fb6ea383f9d6a54db7c81cdf25d39/include/blosc2.h#L114-L129
BLOSC_ERROR
callsBLOSC_TRACE_ERROR
, which prints only if environment variableBLOSC_TRACE
is definedBLOSC_INFO
prints directly if environment variableBLOSC_INFO
is defined. Instead, I think it should callBLOSC_TRACE_INFO
, which prints only if environment variableBLOSC_TRACE
is defined.I realise that it's probably unfeasible to modify things without slightly breaking backwards compatibility, but the current macros don't make sense to me: if environment only variable
BLOSC_INFO
is defined,BLOSC_INFO
will print butBLOSC_ERROR
will not print!