Blosc / python-blosc

A Python wrapper for the extremely fast Blosc compression library
https://www.blosc.org/python-blosc/python-blosc.html
Other
353 stars 73 forks source link

Variant for the © symbol: (C) → (c) #318

Closed DimitriPapadopoulos closed 1 year ago

DimitriPapadopoulos commented 1 year ago

As in https://github.com/Blosc/c-blosc2/pull/472.

DimitriPapadopoulos commented 1 year ago

The CI error is unrelated, I wonder whether aarch64 is still supported by GitHub.

2023-05-01T07:36:33.3389046Z       CMake Warning at blosc/c-blosc/CMakeLists.txt:256 (message):
2023-05-01T07:36:33.3389387Z         Unrecognized system processor aarch64.  Cannot determine which hardware
2023-05-01T07:36:33.3389838Z         features (GNU 10.2.1) supports, so hardware-accelerated implementations
2023-05-01T07:36:33.3390135Z         will not be available.
2023-05-01T07:36:33.3390326Z       
2023-05-01T07:36:33.3390497Z       
2023-05-01T07:36:33.3390782Z       -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2023-05-01T07:36:33.3391128Z       -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
2023-05-01T07:36:33.3391474Z       -- Check if compiler accepts -pthread
2023-05-01T07:36:33.3391817Z       -- Check if compiler accepts -pthread - yes
2023-05-01T07:36:33.3392110Z       -- Found Threads: TRUE
2023-05-01T07:36:33.3392420Z       -- Disabling support for assembly sources in ZSTD
2023-05-01T07:36:33.3393146Z       CMake Error at /tmp/pip-build-env-s5w0_zin/overlay/lib/python3.8/site-packages/skbuild/resources/cmake/FindPythonExtensions.cmake:412 (include_directories):
2023-05-01T07:36:33.3393702Z         include_directories given empty-string as include directory.
2023-05-01T07:36:33.3393991Z       Call Stack (most recent call first):
2023-05-01T07:36:33.3394277Z         blosc/CMakeLists.txt:24 (python_extension_module)
2023-05-01T07:36:33.3397206Z       
2023-05-01T07:36:33.3397370Z       
2023-05-01T07:36:33.3402187Z       _modinit_prefix:PyInit_
2023-05-01T07:36:33.3402623Z       -- Configuring incomplete, errors occurred!
2023-05-01T07:36:33.3402890Z       Traceback (most recent call last):
2023-05-01T07:36:33.3403414Z         File "/tmp/pip-build-env-s5w0_zin/overlay/lib/python3.8/site-packages/skbuild/setuptools_wrap.py", line 666, in setup
2023-05-01T07:36:33.3403789Z           env = cmkr.configure(
2023-05-01T07:36:33.3404270Z         File "/tmp/pip-build-env-s5w0_zin/overlay/lib/python3.8/site-packages/skbuild/cmaker.py", line 356, in configure
2023-05-01T07:36:33.3404618Z           raise SKBuildError(msg)
2023-05-01T07:36:33.3404829Z       
2023-05-01T07:36:33.3405066Z       An error occurred while configuring with CMake.
DimitriPapadopoulos commented 1 year ago

Some updates in the logs between the last commit to the main branch and this pull request:

Perhaps an effect of the CMake version. However, why only for aarch64? It is hard to tell without the actual CMake output.

FrancescAlted commented 1 year ago

Looks good.

Regarding aarch64, it used to work, so this might be a temporary glitch?