search

Blosc / python-blosc2

https://www.blosc.org/python-blosc2
Other
83 stars 19 forks source link

All branches in the conditional structure have same implementation #232

Closed DimitriPapadopoulos closed 3 months ago

DimitriPapadopoulos commented 3 months ago

After https://github.com/Blosc/python-blosc2/commit/587d37b61403d07fa62cbac62c629776ffec3ed7, the following code doesn't look good: https://github.com/Blosc/python-blosc2/blob/57acd81f7a93dd0044384ce2bfdddc3021c6ffce/blosc2/lazyexpr.py#L589-L593

Remove the if/else?

FrancescAlted commented 3 months ago

Good catch. Fixed in https://github.com/Blosc/python-blosc2/commit/b3b6717ad8f4fe3d17beef0949feda3b9ab9e53f