search

Blosc / python-blosc2

https://www.blosc.org/python-blosc2
Other
85 stars 19 forks source link

F841 Local variable `any_persisted` is assigned to but never used #238

Closed DimitriPapadopoulos closed 3 months ago

DimitriPapadopoulos commented 3 months ago

It looks like the ruff linter has discovered a real issue: https://github.com/Blosc/python-blosc2/blob/99525d3141ac802e60b3d7bea4dabd1f2ae92b8f/blosc2/lazyexpr.py#L891-L895

At the very least the comment iter_disk = all_ndarray and any_persisted is misleading: https://github.com/Blosc/python-blosc2/blob/99525d3141ac802e60b3d7bea4dabd1f2ae92b8f/blosc2/lazyexpr.py#L896-L899

FrancescAlted commented 3 months ago

Thanks @DimitriPapadopoulos . I was playing with this lately, and I fixed the unused var just now.