search

BlossomMods / BlossomHomes

Blossom-series /home command and utilities
MIT License
1 stars 7 forks source link

Endless stacking speed bug (+ a way to fix it for users) #17

Open FireI3laze opened 8 months ago

FireI3laze commented 8 months ago

Requirements to cause the bug:

Observation: If you cancle or get canceled during a teleport while having any active speed buff (doesn't have to be Vanilla Minecraft Speed), you will notice your FOV zooming in. If you then log out and back in again, you will notice your speed is permanently increased. This effect is stackable.

Assumption: I assume the "FOV zooming in" means it basically sets your current speed as base speed. So it is not actually zooming in but rather neutralizing the by speed changed FOV to the normal one (since your speed is now considered as normal speed). Once you log back in, you get the speed buffs provided from your current/permanent speed providing buffs additional to your new set base speed. If that is correct, the additionally speed keeps stacking on the base speed, causing the bug

Video how I recreated the bug: https://www.youtube.com/watch?v=AvG6yl7l1Ik

Hope you can solve that issue! Sadly I have to remove the Mod from my Pack until it is fixed.

How I fixed the bug on my server (fabric 0.15.6 api, Minecraft Version 1.20.1): !!!!!BEFORE DOING THAT make sure the player stored their whole inventory in a chest and made a screenshot of their current level!!!!!!

Starting point: servers folder MAKE SURE the server is shut down. First you navigate to the usernamecache.json and keep this file open. It displays the UUID for each player. Then you navigate to: world > playerdata Here you search for the UUID of the player who has the speed bug applied to (the first opened file will help you). To be save you cut their files out and temporarely store them on your Desktop (or any other preferable folder). Once the files are removed from the playerdata folder, you can start the server again. The player will have a cleared inventory and player level and will spawn nearby the world spawn as a new player. (Achievements and Statistics are kept) If this doesn't work, put the backup of the players data back in the folder to avoid further issues and search for a different way to solve the problem.

CodedSakura commented 8 months ago

could you priovide the BlossomHomes.json config file and a mod list?

FireI3laze commented 8 months ago

Sure! The BlossomHomes.json: BlossomHomes.json The mod list: Modlist.txt

I also ran into another issue. I kept stacking the movement speed until this message appeared when trying to rejoin my server: Error

I already tried deleting my playerfiles but it didn't help..

CodedSakura commented 8 months ago

i'm more interested in the config/BlossomMods/BlossomHomes.json file than the player home data file

i will try to find the cause of this, which is likely a mod incompatibility, as i've used the homes command myself a bunch, including around speed beacons and such

FireI3laze commented 8 months ago

Lmao, I was searching through the configs but didn't notice there is another whole folder from this mod in it. Found it now! BlossomHomes.json

Thanks for the effort! The speed sources from other Mods I remember using are:

About my shared screenshot, I am afraid I have no clue how to fix it? I assume the numbers are referring to my players speed?

Edit: I could fix it by joining with a new profile (with the same mods). So I can join my server again ofc. with cleared inventory as mentioned in the first post (not a big deal)

CodedSakura commented 8 months ago

ah, i've found where the bug is, it's not a mod compatibility - i had overlooked how player abilities work

CodedSakura commented 8 months ago

no clue how long before i can fix it (with me attending uni and all), but i'm surprised it's only been reported now, it should've been reported ages ago, as the broken functionality is shared across all my mods

CodedSakura commented 8 months ago

wait, looked at the code and apparently i don't actually do anything with player abilities, only xp and potion effects

so i'll have to look into this deeper

FireI3laze commented 8 months ago

I am surprised too. I guess in Vanilla Minecraft it's uncommon to have Speed buffs during a teleport? Or maybe they changed something in the Vanilla Minecraft code in 1.20+ that causes troubles with your mod? "shared across all my mods" - I assume you were able to recreate the bug then?

But don't worry, take your time!! I am attending university too and it can be hella stress. Maybe you can create a work around by removing the teleport countdown (so no interruption is possible) or making the player invulnerable and being unable to move to - again - avoid any kind of interruption while channeling.

CodedSakura commented 4 months ago

i finally looked into this issue, i had forgotten that i do actually mess with FoV even if they're not enabled in the config. and FoV does mess with player abilities. i've managed to fix the implementation of the FoV effects in the upcoming v3 update for all my mods, i'll leave this issue open until that's published