search

Blount / Cheky

Alerte mail et RSS pour Leboncoin.fr
GNU General Public License v3.0
156 stars 46 forks source link

Option to disable the URL shortener (in SMS notifications) #54

Closed C-Duv closed 6 years ago

C-Duv commented 7 years ago

I don't see any advantage of using an URL shortener in SMS notifications: would you add an config parameter to disable it?

Blount commented 7 years ago

The length of SMSs is limited. The title of alert and of the ad are used to build the message. Also, I need to minimize the size of URL : http://tinyurl.com/gna8kuc is lot shorter than https://www.leboncoin.fr/chaussures/890380423.htm?ca=8_s

C-Duv commented 7 years ago

I understand, looks like I ran into the issue described in the forum where TinyURL URLs were redirecting to empty pages at beta.leboncoin.fr.

That being said, I disabled shortener on my instance and never had issue with SMS length (yet), using Free Mobile SMS service.

cpecquerie commented 6 years ago

One of the issue of forcing tinyurl is that it disables URL schemes on iOS or Android : instead of opening the leboncoin app directly, it will open the browser since the OS detects the tinyurl scheme. I've also disabled TinyURL in my instance manually but an option would be awesome.

Blount commented 6 years ago

I work to disable URL shortener. Two different URL are used : ad url and search URL. The ad url is used when I send a SMS for single ad. The search URL (use to create the alert) is used when more than five ads are found to avoid SMS cost.

Also, search URL can overflow the SMS limitation.

I suggest to remove the URL shortener for ads and conserve it for search URL. What do you think ?

cpecquerie commented 6 years ago 
    Yes it sounds like a great compromise. 

    Obtenez Outlook pour iOS

On Sun, Jul 23, 2017 at 6:33 PM +0200, "Blount" notifications@github.com wrote:

I work to disable URL shortener.

Two different URL are used : ad url and search URL.

The ad url is used when I send a SMS for single ad. The search URL (use to create the alert) is used when more than five ads are found to avoid SMS cost.

Also, search URL can overflow the SMS limitation.

I suggest to remove the URL shortener for ads and conserve it for search URL.

What do you think ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Blount commented 6 years ago

Fixed in 3.6.1. Please, upgrade Cheky to 3.6.1 (after backup ^^).