Make get_camera_parameters use the same message as the app

BluEye-Robotics / ProtocolDefinitions

Collection of protocol definitions for the Blueye underwater drones

GNU Lesser General Public License v3.0

2 stars 3 forks source link

Make get_camera_parameters use the same message as the app #1

Closed aksell closed 5 years ago

aksell commented 5 years ago

Node telecommunication ignores the second char, so any char can be used. But if this is fixed in node_telecommunication it is better for the protocol to be consistent with the app, so that only one place has to be changed. The app sends a "Va", "V" for get camera parameters, and "a" for all.

aksell commented 5 years ago

It would be nice to have a action checking if the json files are valid when pushing

sindrehan commented 5 years ago

Please create an issue for the CI task and I'll implement it later.