search

BluEye-Robotics / ProtocolDefinitions

Collection of protocol definitions for the Blueye Pioneer
GNU Lesser General Public License v3.0
2 stars 3 forks source link

Add AquaTroll message definition (supersedes #112) #116

Closed jp-pino closed 1 year ago

follesoe commented 1 year ago

One thing @jp-pino related to the new messages, double check with @sindrehan on the Python SDK that there are no additional changes needed anywhere in the build/publish pipelines when adding a new .proto file. I appreciate having all AquaTroll related messages in a separate file, but just double check if the C++, Python or something else depends on knowing which files to include etc. I think @johannesschrimpf mentioned something about this when I suggested adding a separate .proto file for Oculus sonar.

For the .NET library there is nothing to worry about, it will generate .NET types for all .proto files.

sindrehan commented 1 year ago

The protobuf generation task in blueye.protocol should handle new files automatically, so no worries on that front.