search

BluEye-Robotics / ProtocolDefinitions

Collection of protocol definitions for the Blueye underwater drones
GNU Lesser General Public License v3.0
2 stars 3 forks source link

add video overlay commands #13

Closed erlenner closed 4 years ago

erlenner commented 4 years ago

Depends on https://github.com/BluEye-Robotics/p2_drone/pull/241

follesoe commented 4 years ago

Are overlays enabled in the current dev build? I can add it as a dev only setting under Camera settings in the app, so that we can start testing (I can also make the app setting so that it forces you to use 720p/25fps if enabling it).

erlenner commented 4 years ago

@follesoe The overlay logic in gst_rtsp_record has been in blunux dev since 1.6.243 (March 5th). However, the bindings between the app protocol and ros service calls are not merged yet: https://github.com/BluEye-Robotics/p2_drone/pull/241.

erlenner commented 4 years ago

But yes, it would be great if you added the setting so we can verify that it works before creating a new dev image.

erlenner commented 4 years ago

https://github.com/BluEye-Robotics/p2_drone/pull/241 is now merged, but I guess we don't merge this until we release the overlay feature, which won't be in 1.6.

sindrehan commented 4 years ago

@erlenner I assume this aligned with the version that was released today, and ready to be merged?

erlenner commented 4 years ago

@sindrehan Yes

erlenner commented 4 years ago

@sindrehan BTW, I used array syntax for these types: https://github.com/BluEye-Robotics/ProtocolDefinitions/pull/13/files#diff-68cea24f7926f9917716826632757ba5R608

Not sure how it plays with the autogenerated python code.

sindrehan commented 4 years ago

Will have to extend the generator the support the array syntax, but that shouldn't be a problem.