search

BluEye-Robotics / ProtocolDefinitions

Collection of protocol definitions for the Blueye underwater drones
GNU Lesser General Public License v3.0
2 stars 3 forks source link

Add command for setting gripper velocities #15

Closed sindrehan closed 4 years ago

sindrehan commented 4 years ago

Went with only gripping and rotational velocity for now, since most grippers support setting the angle directly I think that feature should be added in the future, but it's probably not necessary before we move over to the new protocol.

follesoe commented 4 years ago

Agreed. I would have sent 0 values anyhow for now. And since we are not publishing this protocol definition any time soon, we can still change it without worrying about compatibility issues. So we can also extend the message later if needed. So this looks good to me 👍

sindrehan commented 4 years ago

Well, this repository is public so technically someone could depend on it, but I think it's highly unlikely that we'll run into any problems with that.