BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Set drone time first to address timing issue #110

Closed johannesschrimpf closed 2 years ago

johannesschrimpf commented 2 years ago

Description Due to an initialization issue in the control system, the clock needs to be set right after connection. This will be fixed in Blunux 2.3, but this fix will make it possible to set the initial time also in earlier versions.

Checklist before merging

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (997eb5f) into master (1a61aec) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files           8        8           
  Lines         706      706           
=======================================
  Hits          604      604           
  Misses        102      102           
Flag Coverage Δ
macos_python310 85.55% <100.00%> (ø)
macos_python37 84.37% <100.00%> (ø)
macos_python38 85.55% <100.00%> (ø)
macos_python39 85.55% <100.00%> (ø)
ubuntu_python310 85.55% <100.00%> (ø)
ubuntu_python37 84.37% <100.00%> (ø)
ubuntu_python38 85.55% <100.00%> (ø)
ubuntu_python39 85.55% <100.00%> (ø)
windows_python310 85.53% <100.00%> (ø)
windows_python37 84.35% <100.00%> (ø)
windows_python38 ?
windows_python39 85.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blueye/sdk/drone.py 86.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a61aec...997eb5f. Read the comment docs.