BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Catch ZMQ connection errors #157

Closed sindrehan closed 10 months ago

sindrehan commented 11 months ago

These should only occur if the Django server is up and not the ZMQ server, but they do occur, so it's nice to catch them and reraise as ConnectionErrors.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8d152b) 72.26% compared to head (5ce540e) 72.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #157 +/- ## ========================================== + Coverage 72.26% 72.33% +0.06% ========================================== Files 11 11 Lines 1208 1211 +3 ========================================== + Hits 873 876 +3 Misses 335 335 ``` | [Flag](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | Coverage Δ | | |---|---|---| | [macos-latest_3.10](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [macos-latest_3.11](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [macos-latest_3.12](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [macos-latest_3.9](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.31% <100.00%> (+0.06%)` | :arrow_up: | | [ubuntu-latest_3.10](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [ubuntu-latest_3.11](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [ubuntu-latest_3.12](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.33% <100.00%> (+0.06%)` | :arrow_up: | | [ubuntu-latest_3.9](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.31% <100.00%> (+0.06%)` | :arrow_up: | | [windows-latest_3.10](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.31% <100.00%> (+0.06%)` | :arrow_up: | | [windows-latest_3.11](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.31% <100.00%> (+0.06%)` | :arrow_up: | | [windows-latest_3.12](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.31% <100.00%> (+0.06%)` | :arrow_up: | | [windows-latest_3.9](https://app.codecov.io/gh/BluEye-Robotics/blueye.sdk/pull/157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics) | `72.29% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BluEye-Robotics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.