search

BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Missing dependencies #49

Closed sindrehan closed 4 years ago

sindrehan commented 4 years ago

Describe the bug

The python package on PyPI is missing dependencies on tabulate and requests. These were introduced in #39, but only added as dev-dependencies.

To Reproduce Steps to reproduce the behavior: In a fresh virtualenv:

  1. pip install blueye.sdk
  2. Run import blueye.sdk
  3. See error

Stacktrace

>>> import blueye.sdk
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/__init__.py", line 1, in <module>
    from .pioneer import Pioneer
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/pioneer.py", line 11, in <module>
    from .logs import Logs
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/logs.py", line 3, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

  File "<stdin>", line 1, in <module>
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/__init__.py", line 1, in <module>
    from .pioneer import Pioneer
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/pioneer.py", line 11, in <module>
    from .logs import Logs
  File "/tmp/testvenv/lib/python3.8/site-packages/blueye/sdk/logs.py", line 4, in <module>
    import tabulate
ModuleNotFoundError: No module named 'tabulate'