search

BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Starting recording before opening a video feed does nothing #67

Closed sindrehan closed 1 year ago

sindrehan commented 4 years ago

Describe the bug

If one tries to start a recording before a video pipeline is opened (either through the app, or directly from gstreamer/whatever) nothing happens. This is due to an underlying issue with how video pipelines are initiated.

To Reproduce Steps to reproduce the behavior:

  1. Reboot drone.
  2. from blueye.sdk import Pioneer
p = Pioneer()
p.camera.is_recording  # Returns False, as expected
p.camera.is_recording = True  # Raises no exception
p.camera.is_recording  # Returns False

Expected behavior

The ideal case would be that a recording start regardless of whether a pipeline has been explicitely opened, but raising an exception would also be an improvement over silently failing.

sindrehan commented 1 year ago

As far as I can tell this issue has been fixed now.