BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Add configuration class #77

Closed sindrehan closed 4 years ago

sindrehan commented 4 years ago

Description

This PR adds a Config class containing various functionality for configuring the environment or state of the drone.

Currently it has functions for getting/setting the current water density, and for setting system time on the drone. I've also added a call in the connect() function to automatically set the time when connection is established.

Fixes #76 Fixes #72 #### Checklist before merging - [x] Run the tests while connected to a drone - [x] Add page to documentation explaining the new functions.
lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging ec7be28f5718701c11691004b9538a876ff73a99 into b9b4e5cb1771353bc7858c6436ec5702652456d6 - view on LGTM.com

new alerts:

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will increase coverage by 1.88%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   75.57%   77.45%   +1.88%     
==========================================
  Files           6        7       +1     
  Lines         393      417      +24     
==========================================
+ Hits          297      323      +26     
+ Misses         96       94       -2
Flag Coverage Δ
#macos_python37 100% <ø> (+24.55%) :arrow_up:
#macos_python38 100% <ø> (+24.42%) :arrow_up:
#ubuntu_python37 77.29% <100%> (+1.84%) :arrow_up:
#ubuntu_python38 77.45% <100%> (+1.88%) :arrow_up:
#windows_python37 100% <ø> (+24.55%) :arrow_up:
#windows_python38 77.45% <100%> (+1.88%) :arrow_up:
Impacted Files Coverage Δ
blueye/sdk/constants.py 100% <100%> (ø)
blueye/sdk/pioneer.py 84.51% <100%> (+3.63%) :arrow_up:
blueye/sdk/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9b4e5c...48f16e1. Read the comment docs.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging fcf549699ac17ab96731a4c66ad4f60579dea529 into b9b4e5cb1771353bc7858c6436ec5702652456d6 - view on LGTM.com

new alerts:

sindrehan commented 4 years ago

The issues reported by LGTM are false positives. Reported here and supposedly fixed here. Will probably be rolled out soon.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 6c3ee93f35f62e5c423296e57ab7fe152d71d26a into b9b4e5cb1771353bc7858c6436ec5702652456d6 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging ed342b62acb26f92a5f6b076780b20e29b9c3fcc into b9b4e5cb1771353bc7858c6436ec5702652456d6 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 48f16e1c4f8181601f1f7ebb0236374c64c592e6 into b9b4e5cb1771353bc7858c6436ec5702652456d6 - view on LGTM.com

new alerts: