BluEye-Robotics / blueye.sdk

A Python package for remote control of Blueye underwater drones.
GNU Lesser General Public License v3.0
17 stars 4 forks source link

Make the SDK drone model agnostic #80

Closed follesoe closed 4 years ago

follesoe commented 4 years ago

Blueye now sells two different drone models:

The SDK is compatible with both models already, which should be communicated in the documentation.

As for the main Pioneer class, I am not sure if we should rename it to something generic such as BlueyeDrone. The SDK is not officially released yet and in terms of backward compatibility, we could either add an empty Pioneer class that derives from BlueyeDrone or we could accept a breaking change?

class Pioneer(BlueyeDrone):
  pass

This way we don't break existing code, such as our own test scripts, or customers who have started using it.