BluSunrize / WitchingGadgets

Thaumcraft Addon for those that still crave more content
25 stars 27 forks source link

Crystal Capsule duplicating finite fluids #110

Open Xavion3 opened 8 years ago

Xavion3 commented 8 years ago

The crystal capsule when used on finite fluids that take up less than a full block such as liquid death or flux goo still fills with a full 1000mB of the fluid.

I know 1.7.10 development is dead for this, but in case anyone ever decides to update it I'm reporting it anyway.

Twisted-Code commented 3 years ago

likewise (yes I know 1.7.10 years a fossil at this point; this is strictly for documentation purposes and not for any expectation of maintenance) I found a bug involving crystal capsules where it can dupe full blocks if you move them from one container to another. I had it happen where I removed some of one of PneumaticCraft fluids from a Thermal Expansion portable tank and put it in a Thermopneumatic Processing Plant by right clicking it like a bucket, it didn't completely clear the data tag (mine tweaker reports the items stack as ".withTag({})". If, subsequently, I had multiple such capsules in the same stack, I could fill them all with one click on the portable tank and it only counted as taking one bucket. I don't know if it's just the TPP causing the problem (I couldn't reproduce it when I right clicked other blocks) or what, but it might be best if the right click callback made sure to clear any empty tags left over before returning.