search

BluSunrize / WitchingGadgets

Thaumcraft Addon for those that still crave more content
25 stars 52 forks source link

Incompatibility with Gadomancy #95

Open HellFirePvP opened 8 years ago

HellFirePvP commented 8 years ago

Greetings,

I and makeo are the developers of Gadomancy curseforge project page: http://minecraft.curseforge.com/projects/gadomancy github: https://github.com/makeoo/Gadomancy

The issue is, we got an imcompatibility issue with your mod on our side which we can't fix.

Issue: https://github.com/makeoo/Gadomancy/issues/34

Basically what's happening: You're checking for TileEntity.getClass().equals(TileNode.class) at some points in your code. The problem is, we're adding a new kind of nodetype and are overwriting the BlockAiry of Thaumcraft to be able to add our tileentities instead of the default thaumcraft ones. So every Node has the TileEntity "TileExtendedNode" (path: makeoo.gadomancy.common.blocks.tiles.TileExtendedNode) and thus tileentity.getClass().equals(TileNode.class) is always false, which is not the case for modpacks where only TC is installed. Unfortunately we cannot do anything about this on our end, so i'd ask you to change your code from "tileentity.getClass().equals(TileNode.class)" to "tileentity instanceof INode" or related. That's not only compatible with our mod, it would also support any other kind of mod that adds its own nodes or whatsoever.

Overall, that's not that big of an issue code-wise, so resolving it as soon as possible would be really awesome!

~HellFirePvP

BluSunrize commented 8 years ago

I'll see to it when I actually work on WG again. Warning: Might be a bit.