Don't `install` DESTDIR

Blub / netevent

Input-Event device cloning utility. Use it together with ssh/netcat/... to share input devices among different machines.

GNU General Public License v2.0

148 stars 14 forks source link

Don't `install` DESTDIR #28

Closed soumya92 closed 1 year ago

soumya92 commented 1 year ago

install -d will create all components anyway, so install -d $(DESTDIR) followed by install -d $(DESTDIR)$(BINDIR) is redundant. Not calling install -d $(DESTDIR) will also allow an unset DESTDIR to act as '/', causing sudo make install to install the package in the filesystem root (currently fails with "missing file operand" due to DESTDIR being empty).

Blub commented 1 year ago

Hi, can you please add a Signed-off-by line to the commit?

soumya92 commented 1 year ago

Done