search

Blub / netevent

Input-Event device cloning utility. Use it together with ssh/netcat/... to share input devices among different machines.
GNU General Public License v2.0
148 stars 14 forks source link

Zero memset classes, remove unnecessary parenthesis, fixes build error. #6

Closed ShoelaceMan closed 5 years ago

Blub commented 6 years ago

Thanks, but could you please add a Signed-off-by trailer?

ShoelaceMan commented 6 years ago

Hey,

I'm using GCC 8.1.0:

~ 1 g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/8.1.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --enable-libmpx --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp
Thread model: posix
gcc version 8.1.0 (GCC)

As far as a sign off, I'll see about getting that done ASAP.

ShoelaceMan commented 6 years ago

Hey, can this be merged yet? I'd like to deploy this via the makepkg.

Blub commented 6 years ago

Please squash the two commits, add a Signed-off-by line to it and force-push it to the branch to update the pull request, then I'll merge it.

Blub commented 5 years ago

Do you wanna fixup the branch? I'd really prefer the a single PR to not have a fixup commit for another commit itself introduces. Also, the Sign-off-by line...