SignalReceiver PR

[paulgrammy]

Features:

• SignalReceiver is a base of RemoteControl

• If position and orientation information have been received through settingsCallback, the app will save them in a list of traffic participants

• this list is later processed while the robot is driving

• once the robot points towards and is close to the given position of the IE, it sends the last color sent by the IE through SMP to RU

• designed to work alongside the DCS app EndlessRun

Sorry again for the big PR

[paulgrammy]

The overall success rate on target (meaning successful traffic handling by stopping at a red light, etc.) is around 60%. I will try to improve this while working on the findings of the current app state.

[BlueAndi]

@paulgrammy @KaiGlaesker @NTDavidS These kind of big-bang PRs are not manageable. The effort for the review is very high and the effort to fix the stuff as well. And please consider it has to be done in the RadonUlzer as well, see https://github.com/BlueAndi/RadonUlzer/pull/85

The probability to destroy other applications is high! And for sure, no one can focus on the problems in the logic anymore.

[KaiGlaesker]

@paulgrammy @KaiGlaesker @NTDavidS These kind of big-bang PRs are not manageable. The effort for the review is very high and the effort to fix the stuff as well. And please consider it has to be done in the RadonUlzer as well, see BlueAndi/RadonUlzer#85

The probability to destroy other applications is high! And for sure, no one can focus on the problems in the logic anymore.

Hi Andi,

yes I agree. The amount of reviewing the whole content is too high (also for me). Therefore we should clarify, how we proceed so that all stakeholders can close their tasks.

Please follow my invitation for next week as the ping pong here does not lead to a solution - I guess.

Best Regards Kai :)

[BlueAndi]

@paulgrammy @KaiGlaesker @NTDavidS These kind of big-bang PRs are not manageable. The effort for the review is very high and the effort to fix the stuff as well. And please consider it has to be done in the RadonUlzer as well, see BlueAndi/RadonUlzer#85 The probability to destroy other applications is high! And for sure, no one can focus on the problems in the logic anymore.

Hi Andi,

yes I agree. The amount of reviewing the whole content is too high (also for me). Therefore we should clarify, how we proceed so that all stakeholders can close their tasks.

Please follow my invitation for next week as the ping pong here does not lead to a solution - I guess.

Best Regards Kai :)

@KaiGlaesker Did I receive an invitation via Outlook? If yes, I need to check it again.

[gabryelreyes]

The following files have the wrong Line Ending (they are LF but should be CRLF): eol.txt

[BlueAndi]

@BlueAndi @KaiGlaesker @NTDavidS Looks good to me. Now there are only files relevant to the Application. Style and documentation should be mostly correct now.

For me its ok as well, my focus was mainly that other Apps were not touched.

[BlueAndi]

@paulgrammy Can you fix the conflicting files?