search

BlueAndi / Pixelix

Full RGB LED matrix, based on an ESP32 and WS2812B LEDs.
MIT License
300 stars 59 forks source link

[Bug] DateTimePlugin lamp color configuration always the default #178

Closed ryannevell closed 2 months ago

ryannevell commented 2 months ago

Describe the bug It does not appear to be possible to change the color of the lamps used in the DateTimePlugin.

To Reproduce Steps to reproduce the behavior:

  1. Install DateTimePlugin into a slot
  2. Plugins→DateTimePlugin
  3. Change value of "Color of actual day" or "Color of other days"
  4. Click "Update"
  5. No color change observed

Expected behavior The lamp colors should reflect the colors entered in the settings page.

Please complete the following information:

ryannevell commented 2 months ago

I think this may be happening because the colors are assigned to the lamp objects in DateTimePlugin::start, and remain cached there. So even after DateTimePlugin::setConfiguration changes m_dayOnColor and m_dayOffColor, those new values are not propagated to the 7 LampWidget instances.

BlueAndi commented 2 months ago

Can you please check with the Development branch, it contains the latest code base which will be prepared for v8.0.0?

ryannevell commented 2 months ago

I cannot reproduce this on latest Development branch. Closing