Closed nhjschulz closed 3 days ago
The main problem with the PR will be that it doesn't fit anymore. IMHO the threshold is around 99.5%. Maybe we should think about having the mini terminal as service, because the service can be easily removed by configuration. The drawback might be of course that it won't be available for some board configurations.
I think it adds less then 200 bytes, but I can optimize further to be almost size neutral. It should even shrink if we kick out "ping" which is kind of obsolete if you have "help" also. Let me know if I should do this.
The main problem with the PR will be that it doesn't fit anymore. IMHO the threshold is around 99.5%. Maybe we should think about having the mini terminal as service, because the service can be easily removed by configuration. The drawback might be of course that it won't be available for some board configurations.
I think it adds less then 200 bytes, but I can optimize further to be almost size neutral. It should even shrink if we kick out "ping" which is kind of obsolete if you have "help" also. Let me know if I should do this.
Removing "ping" is a good idea, because of the "help" command. I think with that we come back to previous size. I guess I will remove things like the reset monitor in the future, because it just helps for debugging issues. Need to think about other features too.
The main problem with the PR will be that it doesn't fit anymore. IMHO the threshold is around 99.5%. Maybe we should think about having the mini terminal as service, because the service can be easily removed by configuration. The drawback might be of course that it won't be available for some board configurations.
I think it adds less then 200 bytes, but I can optimize further to be almost size neutral. It should even shrink if we kick out "ping" which is kind of obsolete if you have "help" also. Let me know if I should do this.
Removing "ping" is a good idea, because of the "help" command. I think with that we come back to previous size. I guess I will remove things like the reset monitor in the future, because it just helps for debugging issues. Need to think about other features too.
The latest version is ~80 bytes less ROM than the one before the PR (adding text + data) text data bss dec hex filename 1131614 330920 1173405 2635939 2838a3 .\firmware.elf (version before) 1131434 331012 1173381 2635827 283833 .\firmware.elf (with this PR)
Thx!
Added new command help to print the supported commands list.
Side changes: