BlueBrain / AstroVascPy

Vasculature blood flow computation and impact of astrocytic endfeet on vessels
https://astrovascpy.rtfd.io
Apache License 2.0
8 stars 2 forks source link

Introduce a new utils.Graph class #15

Closed tristan0x closed 11 months ago

tristan0x commented 11 months ago

This new class intends to replace the usage of vascpy.PointVasculature instances in the code and get rid of the GRAPH_HELPER class whose API was inconvenient, and its cache implementation dangerous.

An instance of utils.Graph is a vascpy.PointVasculature but with additional methods and cached properties related to graph computation

utils.Graph constructor also sets its edge data so that there is no need to call it explicitely like it was done for vascpy.PointVasculature.

bbpbuildbot commented 11 months ago

Logfiles from GitLab pipeline #167933 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 11 months ago

Logfiles from GitLab pipeline #167945 (:white_check_mark:) have been uploaded here!

Status and direct links:

nico-canta commented 11 months ago

It looks way better than the previous approach! Let's merge it!