Closed nico-canta closed 12 months ago
The functions array2distArray
and coomatrix2PETScMat_naive
are not used. Do we still need them?
I think we can use the function array2PETScVec
here as well. I can add the possibility of converting integer arrays. Is it ok?
I think we can use the function
array2PETScVec
here as well. I can add the possibility of converting integer arrays. Is it ok?
I had issues with array2PETScVec
and integer arrays. While for small arrays it was working ok, with the very large full mouse brain circuit, it was failing. I would leave it as is.
The functions
array2distArray
andcoomatrix2PETScMat_naive
are not used. Do we still need them?
I would leave them for completeness and future reference.
Logfiles from GitLab pipeline #156345 (:no_entry:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #160895 (:no_entry:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #161829 (:no_entry:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #161841 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #161840 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #162687 (:no_entry:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #162695 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #162701 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #162700 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #162709 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #163559 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #163810 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #163816 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #163955 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #164088 (:white_check_mark:) have been uploaded here!
Status and direct links:
Logfiles from GitLab pipeline #164953 (:no_entry:) have been uploaded here!
Status and direct links:
The test I introduced uses the package "pytest-mpi" and is automatically skipped in the CI. Do we keep it? Or remove it? Do we include it in the CI? Shall I add more tests for functions that use mpi?
In Scatterv, I wanted to use MPIU_REAL instead of MPI.DOUBLE, but I couldn't find it from the python bindings. Since we compile with "--with-scalar-type=real", is MPI.Double ok? Or better to make it more flexible?
Open to hearing other comments and suggestions.