BlueBrain / AstroVascPy

Vasculature blood flow computation and impact of astrocytic endfeet on vessels
https://astrovascpy.rtfd.io
Apache License 2.0
8 stars 2 forks source link

petsc array and matrix conversion #5

Closed nico-canta closed 12 months ago

nico-canta commented 1 year ago

Open to hearing other comments and suggestions.

nico-canta commented 1 year ago

The functions array2distArray and coomatrix2PETScMat_naive are not used. Do we still need them?

nico-canta commented 1 year ago

https://github.com/BlueBrain/AstroVascPy/blob/b7e501f6ba9dfb674e12186cbc00576c69c68575/astrovascpy/bloodflow.py#L432

I think we can use the function array2PETScVec here as well. I can add the possibility of converting integer arrays. Is it ok?

kotsaloscv commented 1 year ago

https://github.com/BlueBrain/AstroVascPy/blob/b7e501f6ba9dfb674e12186cbc00576c69c68575/astrovascpy/bloodflow.py#L432

I think we can use the function array2PETScVec here as well. I can add the possibility of converting integer arrays. Is it ok?

I had issues with array2PETScVec and integer arrays. While for small arrays it was working ok, with the very large full mouse brain circuit, it was failing. I would leave it as is.

kotsaloscv commented 1 year ago

The functions array2distArray and coomatrix2PETScMat_naive are not used. Do we still need them?

I would leave them for completeness and future reference.

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #156345 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #160895 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #161829 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #161841 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #161840 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #162687 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #162695 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #162701 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #162700 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #162709 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #163559 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #163810 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #163816 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #163955 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #164088 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 year ago

Logfiles from GitLab pipeline #164953 (:no_entry:) have been uploaded here!

Status and direct links: