search

BlueBrain / Atlas-Download-Tools

Search, download, and prepare brain atlas data.
https://atlas-download-tools.rtfd.io
GNU Lesser General Public License v3.0
17 stars 7 forks source link

Dataset download entrypoint #79

Closed jankrepl closed 3 years ago

jankrepl commented 3 years ago

Closes #78 and closes #54 and closes #82

mypy

  1. I needed to add # type : ignore in b6c5718.
    Check https://github.com/python/mypy/issues/9656 for more info.
  2. I got a second issue mypy, I am not sure how I have to handle it. So I am ignoring it, do not hesitate to tell if you have an idea how to solve this. 
    lint run-test: commands[4] | mypy setup.py src/atldld tests docs
src/atldld/sync.py:322: error: Incompatible types in assignment (expression has type "List[Dict[str, Any]]", target has type "Dict[str, Any]")  [assignment]
EmilieDel commented 3 years ago

@jankrepl @Stannislav Should we merge this PR ?

jankrepl commented 3 years ago

@jankrepl @Stannislav Should we merge this PR ?

Sounds good to me.

jankrepl commented 3 years ago

We should also write a test for the CLI.