BlueBrain / BlueCelluLab

Biologically detailed neural network simulations and analysis API
https://bluecellulab.readthedocs.io/en/latest/
Other
8 stars 12 forks source link

Enable injecting Python generated Stimuli [vcs: #minor] #142

Closed anilbey closed 4 months ago

anilbey commented 4 months ago

Adds a layer to create stimuli in Python and combine them with + operator. It does not use NEURON and it is not dependent on the Cell module. The current trace of each generated stimuli can be retrieved consistently.

Changes

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.61654% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.23%. Comparing base (d7a5240) to head (e39fd4d). Report is 11 commits behind head on main.

Files Patch % Lines
tests/test_stimulus/test_factory.py 94.89% 5 Missing :warning:
bluecellulab/stimulus/factory.py 97.41% 3 Missing :warning:
bluecellulab/cell/injector.py 95.65% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================== + Coverage 85.30% 89.23% +3.92% ========================================== Files 80 87 +7 Lines 5404 5387 -17 ========================================== + Hits 4610 4807 +197 + Misses 794 580 -214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stefanoantonel commented 4 months ago

Looks good to me! If you can just put an example of how to reproduce at least the patterns that we see on the OpenBrainPlatform that would be helpful