Closed anilbey closed 3 months ago
Attention: Patch coverage is 93.24324%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 90.86%. Comparing base (
eb63577
) to head (b629e38
).
Files | Patch % | Lines |
---|---|---|
bluecellulab/cell/core.py | 61.90% | 8 Missing :warning: |
bluecellulab/synapse/synapse_types.py | 62.50% | 6 Missing :warning: |
bluecellulab/utils.py | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
RNGSettings is not Cell or Synapse dependent. It is NEURON dependent. This PR removes the RNGSettings dependency in Cell and Synapse. It also creates the IsolatedProcess to consistently handle the scenarios require running NEURON in isolation. Removing RNGSettings helps there since now there is one less parameter to pass to the subprocess.
Changes