BlueBrain / BlueCelluLab

Biologically detailed neural network simulations and analysis API
https://bluecellulab.readthedocs.io/en/latest/
Other
8 stars 12 forks source link

decouple setting global neuron attributes from sim run [vcs: #minor] #154

Closed anilbey closed 3 months ago

anilbey commented 3 months ago

Separates global neuron simulator attributes such as temperature from the simulation class. Calling simulation.run without specifying temperature no longer overrides neuron.h.temperature with this change.

addresses #153.

The usage is the following:

NeuronGlobals.get_instance().temperature = 34.0
sim.run(duration, cvode=False, dt=dt)
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.85%. Comparing base (8bfa9b5) to head (c2f7536).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #154 +/- ## ========================================== - Coverage 90.86% 90.85% -0.02% ========================================== Files 89 89 Lines 5320 5292 -28 ========================================== - Hits 4834 4808 -26 + Misses 486 484 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anilbey commented 3 months ago

Just added 3 more lines for v_init in a test. Merging once CI succeeds.