search

BlueBrain / BlueCelluLab

Biologically detailed neural network simulations and analysis API
https://bluecellulab.readthedocs.io/en/latest/
Other
8 stars 12 forks source link

amplitude based stimuli in apply_multiple_stimuli #182

Closed AurelienJaquier closed 2 months ago

AurelienJaquier commented 2 months ago

can choose to use apply_multiple_stimuli with amplitude based stimuli by passing raw amplitudes to amplitudes and setting threshold_based to False.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.18%. Comparing base (fcf8ad0) to head (87e8986). Report is 1 commits behind head on main.

Files Patch % Lines
bluecellulab/stimulus/factory.py 79.31% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ========================================== - Coverage 91.23% 91.18% -0.06% ========================================== Files 95 95 Lines 5626 5662 +36 ========================================== + Hits 5133 5163 +30 - Misses 493 499 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AurelienJaquier commented 2 months ago

It looks like my additions to the tests increased the ci testing time. :') Do you think my additional tests are worth the time @anilbey ?

AurelienJaquier commented 2 months ago

Great! This should solve Issue #180