search

BlueBrain / BlueCelluLab

Biologically detailed neural network simulations and analysis API
https://bluecellulab.readthedocs.io/en/latest/
Other
8 stars 12 forks source link

Correct 'projections' for get_syn_descriptions #187

Closed ilkilic closed 1 day ago

ilkilic commented 1 month ago

The rationale for this refactoring is to ensure that get_syn_descriptions returns the description only for the instantiated synapse

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (2e672f7) to head (fbbec9f).

Files Patch % Lines
bluecellulab/circuit_simulation.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #187 +/- ## ======================================= Coverage 91.24% 91.24% ======================================= Files 95 95 Lines 5685 5687 +2 ======================================= + Hits 5187 5189 +2 Misses 498 498 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ilkilic commented 2 days ago

I realized there was some confusion in my previous attempt. I have made some corrections that should now ensure consistency when get_syn_descriptions is called directly by a user