codecov-commenter
commented
1 year ago Codecov Report
Merging #159 (d41e498) into master (c37bf66) will not change coverage. The diff coverage is
0.00%.
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 34 34
Lines 2154 2154
=======================================
Hits 1366 1366
Misses 788 788 | Files Changed | Coverage Δ | |
|---|---|---|
| bluepyefe/ecode/sAHP.py | 16.19% <0.00%> (ø) |
AurelienJaquier
When user has info about step start and end, s/he should inform it to bluepyefe, because automatic step detection cannot always properly detect steps, especially when the trace is noisy and the step amplitude is low.
This PR fixes step detection for a particular trace that made bluepyefe crash. The number 2.0 is ad hoc (as was previously 4.5) and fine tuned by hand to allow a maximum of traces to be properly detected. I tested this on 211 traces from the rat primary somatosensory cortex recorded by lnmc. With 2.0, only 3 traces had ton and toff not properly detected, and bluepyefe did not crash. With a value less than 2.0, we start having tmid and tmid2 values not being properly detected for several traces. With a value larger than 2.0, we have more ton and toff not properly detected.