search

BlueBrain / BluePyEfe

BluePyEfe: Blue Brain Python E-feature extraction
https://bluepyefe.readthedocs.io/en/latest/
Other
15 stars 13 forks source link

use all available cores in feature extraction #176

Open anilbey opened 7 months ago

anilbey commented 7 months ago

With this change the Cell object calls the recording.compute_efeatures in parallel in the extract_efeatures function.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.29%. Comparing base (b5fc0e5) to head (0b3eb99).

Files Patch % Lines
bluepyefe/cell.py 90.90% 2 Missing :warning:
bluepyefe/rheobase.py 77.77% 2 Missing :warning:
tests/test_efel_settings.py 66.66% 2 Missing :warning:
bluepyefe/extract.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #176 +/- ## ========================================== - Coverage 73.76% 73.29% -0.48% ========================================== Files 38 39 +1 Lines 2413 2430 +17 ========================================== + Hits 1780 1781 +1 - Misses 633 649 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

darshanmandge commented 6 months ago

Thanks @anilbey ! I think we should test this with all the readers: ibw, different types of nwb, abf, etc. with a good number of ephys files to see if it works and if it improves the performance. e.g. for ibw files this bluepyemodel example would be a sufficient test.